diff options
| author | Fred Isaman <iisaman@netapp.com> | 2011-02-11 16:42:36 +0100 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2011-03-11 21:38:40 +0100 |
| commit | eabf5baaaaf41b6a0273043cfb06d53dca67acef (patch) | |
| tree | d3af759bccd76ecb3b1f1b5ec027193051b55734 /net | |
| parent | RPC: remove check for impossible condition in rpc_make_runnable (diff) | |
| download | linux-eabf5baaaaf41b6a0273043cfb06d53dca67acef.tar.xz linux-eabf5baaaaf41b6a0273043cfb06d53dca67acef.zip | |
RPC: clarify rpc_run_task error handling
rpc_run_task can only fail if it is not passed in a preallocated task.
However, that is not at all clear with the current code. So
remove several impossible to occur failure checks.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sunrpc/clnt.c | 6 | ||||
| -rw-r--r-- | net/sunrpc/sched.c | 6 |
2 files changed, 0 insertions, 12 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 57d344cf2256..8b5a6b40d37c 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -636,12 +636,6 @@ struct rpc_task *rpc_run_task(const struct rpc_task_setup *task_setup_data) rpc_task_set_client(task, task_setup_data->rpc_client); rpc_task_set_rpc_message(task, task_setup_data->rpc_message); - if (task->tk_status != 0) { - int ret = task->tk_status; - rpc_put_task(task); - return ERR_PTR(ret); - } - if (task->tk_action == NULL) rpc_call_start(task); diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 93107265256d..5681c6a12d20 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -836,12 +836,6 @@ struct rpc_task *rpc_new_task(const struct rpc_task_setup *setup_data) } rpc_init_task(task, setup_data); - if (task->tk_status < 0) { - int err = task->tk_status; - rpc_put_task(task); - return ERR_PTR(err); - } - task->tk_flags |= flags; dprintk("RPC: allocated task %p\n", task); return task; |