summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorAnton Protopopov <a.s.protopopov@gmail.com>2016-02-07 05:31:19 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2016-02-08 13:05:02 +0100
commit5cc6ce9ff27565949a1001a2889a8dd9fd09e772 (patch)
treed79edaa806b1799a965ae2c72b4c6bee4b48ab80 /net
parentnetfilter: tee: select NF_DUP_IPV6 unconditionally (diff)
downloadlinux-5cc6ce9ff27565949a1001a2889a8dd9fd09e772.tar.xz
linux-5cc6ce9ff27565949a1001a2889a8dd9fd09e772.zip
netfilter: nft_counter: fix erroneous return values
The nft_counter_init() and nft_counter_clone() functions should return negative error value -ENOMEM instead of positive ENOMEM. Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
-rw-r--r--net/netfilter/nft_counter.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/net/netfilter/nft_counter.c b/net/netfilter/nft_counter.c
index c7808fc19719..c9743f78f219 100644
--- a/net/netfilter/nft_counter.c
+++ b/net/netfilter/nft_counter.c
@@ -100,7 +100,7 @@ static int nft_counter_init(const struct nft_ctx *ctx,
cpu_stats = netdev_alloc_pcpu_stats(struct nft_counter_percpu);
if (cpu_stats == NULL)
- return ENOMEM;
+ return -ENOMEM;
preempt_disable();
this_cpu = this_cpu_ptr(cpu_stats);
@@ -138,7 +138,7 @@ static int nft_counter_clone(struct nft_expr *dst, const struct nft_expr *src)
cpu_stats = __netdev_alloc_pcpu_stats(struct nft_counter_percpu,
GFP_ATOMIC);
if (cpu_stats == NULL)
- return ENOMEM;
+ return -ENOMEM;
preempt_disable();
this_cpu = this_cpu_ptr(cpu_stats);