diff options
| author | David Ahern <dsahern@gmail.com> | 2019-05-08 05:44:59 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-05-08 18:38:30 +0200 |
| commit | 19e4e768064a87b073a4b4c138b55db70e0cfb9f (patch) | |
| tree | 693ae44cd5a3ecbd326293bcad8ac2fff0b2a407 /net | |
| parent | fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL n... (diff) | |
| download | linux-19e4e768064a87b073a4b4c138b55db70e0cfb9f.tar.xz linux-19e4e768064a87b073a4b4c138b55db70e0cfb9f.zip | |
ipv4: Fix raw socket lookup for local traffic
inet_iif should be used for the raw socket lookup. inet_iif considers
rt_iif which handles the case of local traffic.
As it stands, ping to a local address with the '-I <dev>' option fails
ever since ping was changed to use SO_BINDTODEVICE instead of
cmsg + IP_PKTINFO.
IPv6 works fine.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/raw.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c index c55a5432cf37..dc91c27bb788 100644 --- a/net/ipv4/raw.c +++ b/net/ipv4/raw.c @@ -173,6 +173,7 @@ static int icmp_filter(const struct sock *sk, const struct sk_buff *skb) static int raw_v4_input(struct sk_buff *skb, const struct iphdr *iph, int hash) { int sdif = inet_sdif(skb); + int dif = inet_iif(skb); struct sock *sk; struct hlist_head *head; int delivered = 0; @@ -185,8 +186,7 @@ static int raw_v4_input(struct sk_buff *skb, const struct iphdr *iph, int hash) net = dev_net(skb->dev); sk = __raw_v4_lookup(net, __sk_head(head), iph->protocol, - iph->saddr, iph->daddr, - skb->dev->ifindex, sdif); + iph->saddr, iph->daddr, dif, sdif); while (sk) { delivered = 1; |