summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2008-04-07 22:52:44 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2008-04-09 03:07:00 +0200
commited13c27e546667fb0967ae30f5070cd7f6455f90 (patch)
tree164af7ac3dfd69c6c939150b530fd57a9eb8e54d /net
parentfix bug - executing FDPIC ELF on NFS mount triggers BUG() at mm/nommu.c:862:/... (diff)
downloadlinux-ed13c27e546667fb0967ae30f5070cd7f6455f90.tar.xz
linux-ed13c27e546667fb0967ae30f5070cd7f6455f90.zip
SUNRPC: Fix a memory leak in rpc_create()
Commit 510deb0d was supposed to move the xprt_create_transport() call in rpc_create(), but neglected to remove the old call site. This resulted in a transport leak after every rpc_create() call. This leak is present in 2.6.24 and 2.6.25. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net')
-rw-r--r--net/sunrpc/clnt.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 8c6a7f1a25e9..8834d68972cb 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -261,10 +261,6 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *args)
};
char servername[48];
- xprt = xprt_create_transport(&xprtargs);
- if (IS_ERR(xprt))
- return (struct rpc_clnt *)xprt;
-
/*
* If the caller chooses not to specify a hostname, whip
* up a string representation of the passed-in address.