diff options
| author | Guillaume Nault <g.nault@alphalink.fr> | 2017-03-31 13:02:29 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-02 05:16:41 +0200 |
| commit | 5e6a9e5a3554a5b3db09cdc22253af1849c65dff (patch) | |
| tree | d631fcc1df3f9070c733db94f5be3a0776758392 /net | |
| parent | l2tp: fix duplicate session creation (diff) | |
| download | linux-5e6a9e5a3554a5b3db09cdc22253af1849c65dff.tar.xz linux-5e6a9e5a3554a5b3db09cdc22253af1849c65dff.zip | |
l2tp: hold session while sending creation notifications
l2tp_session_find() doesn't take any reference on the returned session.
Therefore, the session may disappear while sending the notification.
Use l2tp_session_get() instead and decrement session's refcount once
the notification is sent.
Fixes: 33f72e6f0c67 ("l2tp : multicast notification to the registered listeners")
Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/l2tp/l2tp_netlink.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/l2tp/l2tp_netlink.c b/net/l2tp/l2tp_netlink.c index 3620fba31786..f1b68effb077 100644 --- a/net/l2tp/l2tp_netlink.c +++ b/net/l2tp/l2tp_netlink.c @@ -642,10 +642,12 @@ static int l2tp_nl_cmd_session_create(struct sk_buff *skb, struct genl_info *inf session_id, peer_session_id, &cfg); if (ret >= 0) { - session = l2tp_session_find(net, tunnel, session_id); - if (session) + session = l2tp_session_get(net, tunnel, session_id, false); + if (session) { ret = l2tp_session_notify(&l2tp_nl_family, info, session, L2TP_CMD_SESSION_CREATE); + l2tp_session_dec_refcount(session); + } } out: |