diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-06-26 00:42:18 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2023-06-26 17:18:55 +0200 |
| commit | 3e70489721b6c870252c9082c496703677240f53 (patch) | |
| tree | 2186d6851293b5deadfa0199f101c4bd6e8da6a7 /net | |
| parent | netfilter: nf_conntrack_sip: fix the ct_sip_parse_numerical_param() return va... (diff) | |
| download | linux-3e70489721b6c870252c9082c496703677240f53.tar.xz linux-3e70489721b6c870252c9082c496703677240f53.zip | |
netfilter: nf_tables: unbind non-anonymous set if rule construction fails
Otherwise a dangling reference to a rule object that is gone remains
in the set binding list.
Fixes: 26b5a5712eb8 ("netfilter: nf_tables: add NFT_TRANS_PREPARE_ERROR to deal with bound set/chain")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 4c7937fd803f..1d64c163076a 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -5343,6 +5343,8 @@ void nf_tables_deactivate_set(const struct nft_ctx *ctx, struct nft_set *set, nft_set_trans_unbind(ctx, set); if (nft_set_is_anonymous(set)) nft_deactivate_next(ctx->net, set); + else + list_del_rcu(&binding->list); set->use--; break; |