diff options
| author | Jason A. Donenfeld <Jason@zx2c4.com> | 2017-06-08 05:01:20 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2017-06-20 04:06:28 +0200 |
| commit | 7aed9f72c3c70bdc18e72ec086c1a0eafdcd273f (patch) | |
| tree | 721f4c8aee15729fc98cfe1ed2c602397f2fe890 /net | |
| parent | net/neighbor: use get_random_u32 for 32-bit hash random (diff) | |
| download | linux-7aed9f72c3c70bdc18e72ec086c1a0eafdcd273f.tar.xz linux-7aed9f72c3c70bdc18e72ec086c1a0eafdcd273f.zip | |
net/route: use get_random_int for random counter
Using get_random_int here is faster, more fitting of the use case, and
just as cryptographically secure. It also has the benefit of providing
better randomness at early boot, which is when many of these structures
are assigned.
Also, semantically, it's not really proper to have been assigning an
atomic_t in this way before, even if in practice it works fine.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: David Miller <davem@davemloft.net>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/route.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 655d9eebe43e..11e001a42094 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2936,8 +2936,7 @@ static __net_init int rt_genid_init(struct net *net) { atomic_set(&net->ipv4.rt_genid, 0); atomic_set(&net->fnhe_genid, 0); - get_random_bytes(&net->ipv4.dev_addr_genid, - sizeof(net->ipv4.dev_addr_genid)); + atomic_set(&net->ipv4.dev_addr_genid, get_random_int()); return 0; } |