diff options
| author | Florian Westphal <fw@strlen.de> | 2023-08-30 13:00:37 +0200 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2023-08-31 12:33:03 +0200 |
| commit | 8aae7625ff3f0bd5484d01f1b8d5af82e44bec2d (patch) | |
| tree | f93d3927482e78656f29cb1e4c0d0036fed1d0d2 /net | |
| parent | net: read sk->sk_family once in sk_mc_loop() (diff) | |
| download | linux-8aae7625ff3f0bd5484d01f1b8d5af82e44bec2d.tar.xz linux-8aae7625ff3f0bd5484d01f1b8d5af82e44bec2d.zip | |
net: fib: avoid warn splat in flow dissector
New skbs allocated via nf_send_reset() have skb->dev == NULL.
fib*_rules_early_flow_dissect helpers already have a 'struct net'
argument but its not passed down to the flow dissector core, which
will then WARN as it can't derive a net namespace to use:
WARNING: CPU: 0 PID: 0 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0xa91/0x1cd0
[..]
ip_route_me_harder+0x143/0x330
nf_send_reset+0x17c/0x2d0 [nf_reject_ipv4]
nft_reject_inet_eval+0xa9/0xf2 [nft_reject_inet]
nft_do_chain+0x198/0x5d0 [nf_tables]
nft_do_chain_inet+0xa4/0x110 [nf_tables]
nf_hook_slow+0x41/0xc0
ip_local_deliver+0xce/0x110
..
Cc: Stanislav Fomichev <sdf@google.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Ido Schimmel <idosch@nvidia.com>
Fixes: 812fa71f0d96 ("netfilter: Dissect flow after packet mangling")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217826
Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20230830110043.30497-1-fw@strlen.de
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions