diff options
| author | Ben Hutchings <ben@decadent.org.uk> | 2010-08-30 16:15:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-09-02 03:01:55 +0200 |
| commit | 24cd804d1dc60a74c53da983094df3516500c276 (patch) | |
| tree | 5fe89de05b65e4a435d59dcd9992fb63182ddedf /net | |
| parent | sky2: don't do GRO on second port (diff) | |
| download | linux-24cd804d1dc60a74c53da983094df3516500c276.tar.xz linux-24cd804d1dc60a74c53da983094df3516500c276.zip | |
3c59x: Remove incorrect locking; correct documented lock hierarchy
vortex_ioctl() was grabbing vortex_private::lock around its call to
generic_mii_ioctl(). This is no longer necessary since there are more
specific locks which the mdio_{read,write}() functions will obtain.
Worse, those functions do not save and restore IRQ flags when locking
the MII state, so interrupts will be enabled when generic_mii_ioctl()
returns.
Since there is currently no need for any function to call
mdio_{read,write}() while holding another spinlock, do not change them
to save and restore IRQ flags but remove the specification of ordering
between vortex_private::lock and vortex_private::mii_lock.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions