diff options
author | Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2022-08-25 13:36:44 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-08-29 14:02:26 +0200 |
commit | 3f8ae9fe0409698799e173f698b714f34570b64b (patch) | |
tree | bf7550925227acac89bd5810c751976bfcd9fe3d /net | |
parent | r8152: add PID for the Lenovo OneLink+ Dock (diff) | |
download | linux-3f8ae9fe0409698799e173f698b714f34570b64b.tar.xz linux-3f8ae9fe0409698799e173f698b714f34570b64b.zip |
net: dsa: xrs700x: Use irqsave variant for u64 stats update
xrs700x_read_port_counters() updates the stats from a worker using the
u64_stats_update_begin() version. This is okay on 32-UP since on the
reader side preemption is disabled.
On 32bit-SMP the writer can be preempted by the reader at which point
the reader will spin on the seqcount until writer continues and
completes the update.
Assigning the mib_mutex mutex to the underlying seqcount would ensure
proper synchronisation. The API for that on the u64_stats_init() side
isn't available. Since it is the only user, just use disable interrupts
during the update.
Use u64_stats_update_begin_irqsave() on the writer side to ensure an
uninterrupted update.
Fixes: ee00b24f32eb8 ("net: dsa: add Arrow SpeedChips XRS700x driver")
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: George McCollister <george.mccollister@gmail.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>
Cc: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: George McCollister <george.mccollister@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions