summaryrefslogtreecommitdiffstats
path: root/samples
diff options
context:
space:
mode:
authorJuhee Kang <claudiajkang@gmail.com>2021-08-12 17:08:12 +0200
committerDavid S. Miller <davem@davemloft.net>2021-08-16 12:02:09 +0200
commit7caeabd726f22e6a6c44c434574fb489986e5baa (patch)
tree3d3c6d4d3526b02a54edb86e693b4c05e7ac5710 /samples
parentMerge branch 'ipq-mdio' (diff)
downloadlinux-7caeabd726f22e6a6c44c434574fb489986e5baa.tar.xz
linux-7caeabd726f22e6a6c44c434574fb489986e5baa.zip
samples: pktgen: pass the environment variable of normal user to sudo
All pktgen samples can use the environment variable instead of option parameters(eg. $DEV is able to use instead of '-i' option). This is results of running sample as root and user: // running as root # DEV=eth0 DEST_IP=10.1.0.1 DST_MAC=00:11:22:33:44:55 ./pktgen_sample01_simple.sh -v -n 1 Running... ctrl^C to stop // running as normal user $ DEV=eth0 DEST_IP=10.1.0.1 DST_MAC=00:11:22:33:44:55 ./pktgen_sample01_simple.sh -v -n 1 [...] ERROR: Please specify output device This results show the sample doesn't work properly when the sample runs as normal user. Because the sample is restarted by the function (root_check_run_with_sudo) to run with sudo. In this process, the environment variable of normal user doesn't propagate to sudo. It can be solved by using "-E"(--preserve-env) option of "sudo", which preserve normal user's existing environment variables. So this commit adds "-E" option in the function (root_check_run_with_sudo). Signed-off-by: Juhee Kang <claudiajkang@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples')
-rw-r--r--samples/pktgen/functions.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/samples/pktgen/functions.sh b/samples/pktgen/functions.sh
index a335393157eb..933194257a24 100644
--- a/samples/pktgen/functions.sh
+++ b/samples/pktgen/functions.sh
@@ -123,7 +123,7 @@ function root_check_run_with_sudo() {
if [ "$EUID" -ne 0 ]; then
if [ -x $0 ]; then # Directly executable use sudo
info "Not root, running with sudo"
- sudo "$0" "$@"
+ sudo -E "$0" "$@"
exit $?
fi
err 4 "cannot perform sudo run of $0"