summaryrefslogtreecommitdiffstats
path: root/samples
diff options
context:
space:
mode:
authorRobin Murphy <robin.murphy@arm.com>2016-11-07 19:25:09 +0100
committerJoerg Roedel <jroedel@suse.de>2016-11-08 14:52:41 +0100
commit8c82d6ec5abcf9691d37f329bf5f42f6868405db (patch)
tree2f7cfe5ecec2af776e9514340a4f3e4746ad185a /samples
parentiommu/arm-smmu: Check that iommu_fwspecs are ours (diff)
downloadlinux-8c82d6ec5abcf9691d37f329bf5f42f6868405db.tar.xz
linux-8c82d6ec5abcf9691d37f329bf5f42f6868405db.zip
iommu/arm-smmu: Fix out-of-bounds dereference
When we iterate a master's config entries, what we generally care about is the entry's stream map index, rather than the entry index itself, so it's nice to have the iterator automatically assign the former from the latter. Unfortunately, booting with KASAN reveals the oversight that using a simple comma operator results in the entry index being dereferenced before being checked for validity, so we always access one element past the end of the fwspec array. Flip things around so that the check always happens before the index may be dereferenced. Fixes: adfec2e709d2 ("iommu/arm-smmu: Convert to iommu_fwspec") Reported-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Robin Murphy <robin.murphy@arm.com> Acked-by: Will Deacon <will.deacon@arm.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions