diff options
author | Dave Chinner <dchinner@redhat.com> | 2012-05-08 12:48:53 +0200 |
---|---|---|
committer | Ben Myers <bpm@sgi.com> | 2012-05-21 17:45:43 +0200 |
commit | ea562ed6e7df5acd9392d993882c39e855099165 (patch) | |
tree | 0f91e73ae2adba9e0469a7a87abe44c13a880c70 /samples | |
parent | xfs: protect xfs_sync_worker with s_umount semaphore (diff) | |
download | linux-ea562ed6e7df5acd9392d993882c39e855099165.tar.xz linux-ea562ed6e7df5acd9392d993882c39e855099165.zip |
xfs: fix delalloc quota accounting on failure
xfstest 270 was causing quota reservations way beyond what was sane
(ten to hundreds of TB) for a 4GB filesystem. There's a sign problem
in the error handling path of xfs_bmapi_reserve_delalloc() because
xfs_trans_unreserve_quota_nblks() simple negates the value passed -
which doesn't work for an unsigned variable. This causes
reservations of close to 2^32 block instead of removing a
reservation of a handful of blocks.
Fix the same problem in the other xfs_trans_unreserve_quota_nblks()
callers where unsigned integer variables are used, too.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions