diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2022-12-29 10:15:00 +0100 |
---|---|---|
committer | Masahiro Yamada <masahiroy@kernel.org> | 2023-01-22 15:43:33 +0100 |
commit | 92215e7a801da7b89037a185c98f5ebb86a415b9 (patch) | |
tree | 3c1547bd8226598cc84cbeaa351f84d86ef6badf /scripts/bin2c.c | |
parent | kbuild: make W=1 warn files that are tracked but ignored by git (diff) | |
download | linux-92215e7a801da7b89037a185c98f5ebb86a415b9.tar.xz linux-92215e7a801da7b89037a185c98f5ebb86a415b9.zip |
kbuild: rename cmd_$@ to savedcmd_$@ in *.cmd files
The cmd-check macro compares $(cmd_$@) and $(cmd_$1), but a pitfall is
that you cannot use cmd_<target> as the variable name for the command.
For example, the following code will not work in the top Makefile
or ./Kbuild.
quiet_cmd_foo = GEN $@
cmd_foo = touch $@
targets += foo
foo: FORCE
$(call if_changed,foo)
In this case, both $@ and $1 are expanded to 'foo', so $(cmd_check)
is always empty.
We do not need to use the same prefix for cmd_$@ and cmd_$1.
Rename the former to savedcmd_$@.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Diffstat (limited to 'scripts/bin2c.c')
0 files changed, 0 insertions, 0 deletions