summaryrefslogtreecommitdiffstats
path: root/scripts/checkpatch.pl
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2013-04-30 01:18:14 +0200
committerLinus Torvalds <torvalds@linux-foundation.org>2013-04-30 03:28:20 +0200
commit04db4d25d9eaa58140520f976994d1a601129c00 (patch)
treeef0f2c8c04f8deba8fd9ea9b81d00edbda3f575e /scripts/checkpatch.pl
parentcheckpatch: Prefer seq_puts to seq_printf (diff)
downloadlinux-04db4d25d9eaa58140520f976994d1a601129c00.tar.xz
linux-04db4d25d9eaa58140520f976994d1a601129c00.zip
checkpatch: complain about executable files
Complain about files with an executable bit set that are not in a scripts/ directory and are not type .pl, .py, .awk, or .sh Based on an initial patch from Stephen. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
-rwxr-xr-xscripts/checkpatch.pl3
1 files changed, 2 insertions, 1 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b8b03aa52beb..9cdd147c1335 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1583,7 +1583,8 @@ sub process {
# Check for incorrect file permissions
if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
my $permhere = $here . "FILE: $realfile\n";
- if ($realfile =~ /(Makefile|Kconfig|\.c|\.h|\.S|\.tmpl)$/) {
+ if ($realfile !~ m@scripts/@ &&
+ $realfile !~ /\.(py|pl|awk|sh)$/) {
ERROR("EXECUTE_PERMISSIONS",
"do not set execute permissions for source files\n" . $permhere);
}