diff options
| author | Alex Dewar <alex.dewar90@gmail.com> | 2020-08-21 01:55:57 +0200 |
|---|---|---|
| committer | Julia Lawall <Julia.Lawall@lip6.fr> | 2020-08-21 22:35:40 +0200 |
| commit | 7a2624e6de03050c9f15af21c216818d5508b5e9 (patch) | |
| tree | 38ab3ae6ed6eb80ceef417659ca8ef4fa47c5592 /scripts/coccinelle/api/alloc/zalloc-simple.cocci | |
| parent | scripts: coccicheck: Add chain mode to list of modes (diff) | |
| download | linux-7a2624e6de03050c9f15af21c216818d5508b5e9.tar.xz linux-7a2624e6de03050c9f15af21c216818d5508b5e9.zip | |
coccinelle: add patch rule for dma_alloc_coherent
Commit dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()")
removed the definition of dma_zalloc_coherent() and also removed the
corresponding patch rule for replacing instances of dma_alloc_coherent +
memset in zalloc-simple.cocci (though left the report rule).
Add a new patch rule to remove unnecessary calls to memset after
allocating with dma_alloc_coherent. While we're at it, fix a couple of
typos.
Fixes: dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()")
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Diffstat (limited to 'scripts/coccinelle/api/alloc/zalloc-simple.cocci')
| -rw-r--r-- | scripts/coccinelle/api/alloc/zalloc-simple.cocci | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/scripts/coccinelle/api/alloc/zalloc-simple.cocci b/scripts/coccinelle/api/alloc/zalloc-simple.cocci index 26cda3f48f01..b3d0c3c230c1 100644 --- a/scripts/coccinelle/api/alloc/zalloc-simple.cocci +++ b/scripts/coccinelle/api/alloc/zalloc-simple.cocci @@ -127,6 +127,16 @@ statement S; if ((x==NULL) || ...) S - memset((T2)x,0,E1); +@depends on patch@ +type T, T2; +expression x; +expression E1,E2,E3,E4; +statement S; +@@ + x = (T)dma_alloc_coherent(E1, E2, E3, E4); + if ((x==NULL) || ...) S +- memset((T2)x, 0, E2); + //---------------------------------------------------------- // For org mode //---------------------------------------------------------- @@ -199,9 +209,9 @@ statement S; position p; @@ - x = (T)dma_alloc_coherent@p(E2,E1,E3,E4); + x = (T)dma_alloc_coherent@p(E1,E2,E3,E4); if ((x==NULL) || ...) S - memset((T2)x,0,E1); + memset((T2)x,0,E2); @script:python depends on org@ p << r2.p; @@ -217,7 +227,7 @@ p << r2.p; x << r2.x; @@ -msg="WARNING: dma_alloc_coherent use in %s already zeroes out memory, so memset is not needed" % (x) +msg="WARNING: dma_alloc_coherent used in %s already zeroes out memory, so memset is not needed" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- |