summaryrefslogtreecommitdiffstats
path: root/scripts/kconfig/expr.c
diff options
context:
space:
mode:
authorMasahiro Yamada <masahiroy@kernel.org>2024-06-11 19:55:10 +0200
committerMasahiro Yamada <masahiroy@kernel.org>2024-07-15 18:08:36 +0200
commitcd90952101c86267193b263ed3f0753f0715700e (patch)
tree124ed4cdc7b553e892c17d4d353887049440abb1 /scripts/kconfig/expr.c
parentkconfig: add -e and -u options to *conf-cfg.sh scripts (diff)
downloadlinux-cd90952101c86267193b263ed3f0753f0715700e.tar.xz
linux-cd90952101c86267193b263ed3f0753f0715700e.zip
kconfig: remove unneeded code in expr_compare_type()
The condition (t2 == 0) never becomes true because the zero value (i.e., E_NONE) is only used as a dummy type for prevtoken. It can be passed to t1, but not to t2. The caller of this function only checks expr_compare_type() > 0. Therefore, the distinction between 0 and -1 is unnecessary. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to '')
-rw-r--r--scripts/kconfig/expr.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index fcc190b67b6f..31737b2cb8e2 100644
--- a/scripts/kconfig/expr.c
+++ b/scripts/kconfig/expr.c
@@ -1096,11 +1096,8 @@ static int expr_compare_type(enum expr_type t1, enum expr_type t2)
case E_OR:
if (t2 == E_LIST)
return 1;
- case E_LIST:
- if (t2 == 0)
- return 1;
default:
- return -1;
+ break;
}
return 0;
}