summaryrefslogtreecommitdiffstats
path: root/scripts
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2012-09-16 10:50:30 +0200
committerMarcelo Tosatti <mtosatti@redhat.com>2012-09-17 18:46:32 +0200
commit9fc77441e5e1bf80b794cc546d2243ee9f4afb75 (patch)
tree4661976f4fea7606a54b3f5276c0ecb45760979c /scripts
parentKVM: SVM: Make use of asm.h (diff)
downloadlinux-9fc77441e5e1bf80b794cc546d2243ee9f4afb75.tar.xz
linux-9fc77441e5e1bf80b794cc546d2243ee9f4afb75.zip
KVM: make processes waiting on vcpu mutex killable
vcpu mutex can be held for unlimited time so taking it with mutex_lock on an ioctl is wrong: one process could be passed a vcpu fd and call this ioctl on the vcpu used by another process, it will then be unkillable until the owner exits. Call mutex_lock_killable instead and return status. Note: mutex_lock_interruptible would be even nicer, but I am not sure all users are prepared to handle EINTR from these ioctls. They might misinterpret it as an error. Cleanup paths expect a vcpu that can't be used by any userspace so this will always succeed - catch bugs by calling BUG_ON. Catch callers that don't check return state by adding __must_check. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions