diff options
| author | Kees Cook <keescook@chromium.org> | 2023-01-13 00:03:16 +0100 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2023-01-14 00:22:03 +0100 |
| commit | 3b293487b8752cc42c1cbf8a0447bc6076c075fa (patch) | |
| tree | 7503d756954f04b7a1b354fb8bdcdc506e17f4df /scripts | |
| parent | Linux 6.2-rc2 (diff) | |
| download | linux-3b293487b8752cc42c1cbf8a0447bc6076c075fa.tar.xz linux-3b293487b8752cc42c1cbf8a0447bc6076c075fa.zip | |
firmware: coreboot: Check size of table entry and use flex-array
The memcpy() of the data following a coreboot_table_entry couldn't
be evaluated by the compiler under CONFIG_FORTIFY_SOURCE. To make it
easier to reason about, add an explicit flexible array member to struct
coreboot_device so the entire entry can be copied at once. Additionally,
validate the sizes before copying. Avoids this run-time false positive
warning:
memcpy: detected field-spanning write (size 168) of single field "&device->entry" at drivers/firmware/google/coreboot_table.c:103 (size 8)
Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/all/03ae2704-8c30-f9f0-215b-7cdf4ad35a9a@molgen.mpg.de/
Cc: Jack Rosenthal <jrosenth@chromium.org>
Cc: Guenter Roeck <groeck@chromium.org>
Cc: Julius Werner <jwerner@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Link: https://lore.kernel.org/r/20230107031406.gonna.761-kees@kernel.org
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Link: https://lore.kernel.org/r/20230112230312.give.446-kees@kernel.org
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions