diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2023-11-18 08:59:07 +0100 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2023-11-28 03:22:51 +0100 |
| commit | 4d137ab0107ead0f2590fc0314e627431e3b9e3f (patch) | |
| tree | 77ffa566dc209a48361dbab3c3ac83c56ec14952 /scripts | |
| parent | kconfig: remove error check for xrealloc() (diff) | |
| download | linux-4d137ab0107ead0f2590fc0314e627431e3b9e3f.tar.xz linux-4d137ab0107ead0f2590fc0314e627431e3b9e3f.zip | |
kconfig: require a space after '#' for valid input
Currently, when an input line starts with '#', (line + 2) is passed to
memcmp() without checking line[1].
It means that line[1] can be any arbitrary character. For example,
"#KCONFIG_FOO is not set" is accepted as valid input, functioning the
same as "# CONFIG_FOO is not set".
More importantly, this can potentially lead to a buffer overrun if
line[1] == '\0'. It occurs if the input only contains '#', as
(line + 2) points to an uninitialized buffer.
Check line[1], and skip the line if it is not a space.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts')
| -rw-r--r-- | scripts/kconfig/confdata.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 2ba4dfdd1aee..556b7f087dbb 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -426,6 +426,8 @@ load: conf_lineno++; sym = NULL; if (line[0] == '#') { + if (line[1] != ' ') + continue; if (memcmp(line + 2, CONFIG_, strlen(CONFIG_))) continue; p = strchr(line + 2 + strlen(CONFIG_), ' '); |