diff options
| author | Eric Biggers <ebiggers@google.com> | 2018-11-14 21:21:11 +0100 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2018-11-20 07:26:55 +0100 |
| commit | 3d234b3313cd12157946522fe35f5a4574f31169 (patch) | |
| tree | 7d7f105aaa99a8d2c21d9e1d996330dcf95c40c6 /security/apparmor | |
| parent | crypto: drop mask=CRYPTO_ALG_ASYNC from 'cipher' tfm allocations (diff) | |
| download | linux-3d234b3313cd12157946522fe35f5a4574f31169.tar.xz linux-3d234b3313cd12157946522fe35f5a4574f31169.zip | |
crypto: drop mask=CRYPTO_ALG_ASYNC from 'shash' tfm allocations
'shash' algorithms are always synchronous, so passing CRYPTO_ALG_ASYNC
in the mask to crypto_alloc_shash() has no effect. Many users therefore
already don't pass it, but some still do. This inconsistency can cause
confusion, especially since the way the 'mask' argument works is
somewhat counterintuitive.
Thus, just remove the unneeded CRYPTO_ALG_ASYNC flags.
This patch shouldn't change any actual behavior.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'security/apparmor')
| -rw-r--r-- | security/apparmor/crypto.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/crypto.c b/security/apparmor/crypto.c index 136f2a047836..af03d98c7552 100644 --- a/security/apparmor/crypto.c +++ b/security/apparmor/crypto.c @@ -112,7 +112,7 @@ static int __init init_profile_hash(void) if (!apparmor_initialized) return 0; - tfm = crypto_alloc_shash("sha1", 0, CRYPTO_ALG_ASYNC); + tfm = crypto_alloc_shash("sha1", 0, 0); if (IS_ERR(tfm)) { int error = PTR_ERR(tfm); AA_ERROR("failed to setup profile sha1 hashing: %d\n", error); |