diff options
| author | Eric Paris <eparis@redhat.com> | 2009-05-11 19:59:16 +0200 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2009-05-12 03:06:04 +0200 |
| commit | f06dd16a03f6f7f72fab4db03be36e28c28c6fd6 (patch) | |
| tree | 6542e8474a2eff0543b20ac4eb2bb2811d23fc3e /security/integrity | |
| parent | IMA: use current_cred() instead of current->cred (diff) | |
| download | linux-f06dd16a03f6f7f72fab4db03be36e28c28c6fd6.tar.xz linux-f06dd16a03f6f7f72fab4db03be36e28c28c6fd6.zip | |
IMA: Handle dentry_open failures
Currently IMA does not handle failures from dentry_open(). This means that we
leave a pointer set to ERR_PTR(errno) and then try to use it just a few lines
later in fput(). Oops.
Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: Mimi Zohar <zohar@us.ibm.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security/integrity')
| -rw-r--r-- | security/integrity/ima/ima_main.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c index cdae13c5ae05..1987424623c2 100644 --- a/security/integrity/ima/ima_main.c +++ b/security/integrity/ima/ima_main.c @@ -116,10 +116,6 @@ static int get_path_measurement(struct ima_iint_cache *iint, struct file *file, { int rc = 0; - if (IS_ERR(file)) { - pr_info("%s dentry_open failed\n", filename); - return rc; - } iint->opencount++; iint->readcount++; @@ -185,6 +181,12 @@ int ima_path_check(struct path *path, int mask) struct vfsmount *mnt = mntget(path->mnt); file = dentry_open(dentry, mnt, O_RDONLY, current_cred()); + if (IS_ERR(file)) { + pr_info("%s dentry_open failed\n", dentry->d_name.name); + rc = PTR_ERR(file); + file = NULL; + goto out; + } rc = get_path_measurement(iint, file, dentry->d_name.name); } out: |