diff options
| author | Paul Moore <paul@paul-moore.com> | 2016-08-30 23:19:13 +0200 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2016-08-30 23:19:13 +0200 |
| commit | fa2bea2f5cca5b8d4a3e5520d2e8c0ede67ac108 (patch) | |
| tree | a7f49ec5a58e527f6a50cac7a628561688007629 /security/lsm_audit.c | |
| parent | Linux 4.7 (diff) | |
| download | linux-fa2bea2f5cca5b8d4a3e5520d2e8c0ede67ac108.tar.xz linux-fa2bea2f5cca5b8d4a3e5520d2e8c0ede67ac108.zip | |
audit: consistently record PIDs with task_tgid_nr()
Unfortunately we record PIDs in audit records using a variety of
methods despite the correct way being the use of task_tgid_nr().
This patch converts all of these callers, except for the case of
AUDIT_SET in audit_receive_msg() (see the comment in the code).
Reported-by: Jeff Vander Stoep <jeffv@google.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security/lsm_audit.c')
| -rw-r--r-- | security/lsm_audit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/lsm_audit.c b/security/lsm_audit.c index cccbf3068cdc..45d927ab807d 100644 --- a/security/lsm_audit.c +++ b/security/lsm_audit.c @@ -220,7 +220,7 @@ static void dump_common_audit_data(struct audit_buffer *ab, */ BUILD_BUG_ON(sizeof(a->u) > sizeof(void *)*2); - audit_log_format(ab, " pid=%d comm=", task_pid_nr(current)); + audit_log_format(ab, " pid=%d comm=", task_tgid_nr(current)); audit_log_untrustedstring(ab, memcpy(comm, current->comm, sizeof(comm))); switch (a->type) { @@ -294,7 +294,7 @@ static void dump_common_audit_data(struct audit_buffer *ab, case LSM_AUDIT_DATA_TASK: { struct task_struct *tsk = a->u.tsk; if (tsk) { - pid_t pid = task_pid_nr(tsk); + pid_t pid = task_tgid_nr(tsk); if (pid) { char comm[sizeof(tsk->comm)]; audit_log_format(ab, " opid=%d ocomm=", pid); |