diff options
| author | Eric Paris <eparis@redhat.com> | 2011-04-28 21:11:21 +0200 |
|---|---|---|
| committer | Eric Paris <eparis@redhat.com> | 2011-04-28 21:15:52 +0200 |
| commit | 03a4c0182a156547edd5f2717c1702590fe36bbf (patch) | |
| tree | c4585fab7c37d4eb2cc46e93c925e7c2a5e7b1a2 /security/selinux/ss/services.c | |
| parent | SELinux: rename filename_compute_type argument to *type instead of *con (diff) | |
| download | linux-03a4c0182a156547edd5f2717c1702590fe36bbf.tar.xz linux-03a4c0182a156547edd5f2717c1702590fe36bbf.zip | |
SELinux: skip filename trans rules if ttype does not match parent dir
Right now we walk to filename trans rule list for every inode that is
created. First passes at policy using this facility creates around 5000
filename trans rules. Running a list of 5000 entries every time is a bad
idea. This patch adds a new ebitmap to policy which has a bit set for each
ttype that has at least 1 filename trans rule. Thus when an inode is
created we can quickly determine if any rules exist for this parent
directory type and can skip the list if we know there is definitely no
relevant entry.
Signed-off-by: Eric Paris <eparis@redhat.com>
Reviewed-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security/selinux/ss/services.c')
| -rw-r--r-- | security/selinux/ss/services.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index 78bb8100b02e..6a22eaebf3b7 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -1363,6 +1363,15 @@ static void filename_compute_type(struct policydb *p, struct context *newcontext const char *objname) { struct filename_trans *ft; + + /* + * Most filename trans rules are going to live in specific directories + * like /dev or /var/run. This bitmap will quickly skip rule searches + * if the ttype does not contain any rules. + */ + if (!ebitmap_get_bit(&p->filename_trans_ttypes, ttype)) + return; + for (ft = p->filename_trans; ft; ft = ft->next) { if (ft->stype == stype && ft->ttype == ttype && |