diff options
| author | Khadija Kamran <kamrankhadijadj@gmail.com> | 2023-08-07 08:59:29 +0200 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2023-08-08 22:48:47 +0200 |
| commit | 6672efbb685f7c9c9df005beb839e1942fd6b34e (patch) | |
| tree | e29f61323cc3b5923c4013248381cb6382c2ca0e /security/selinux | |
| parent | lsm: add comment block for security_sk_classify_flow LSM hook (diff) | |
| download | linux-6672efbb685f7c9c9df005beb839e1942fd6b34e.tar.xz linux-6672efbb685f7c9c9df005beb839e1942fd6b34e.zip | |
lsm: constify the 'target' parameter in security_capget()
Three LSMs register the implementations for the "capget" hook: AppArmor,
SELinux, and the normal capability code. Looking at the function
implementations we may observe that the first parameter "target" is not
changing.
Mark the first argument "target" of LSM hook security_capget() as
"const" since it will not be changing in the LSM hook.
cap_capget() LSM hook declaration exceeds the 80 characters per line
limit. Split the function declaration to multiple lines to decrease the
line length.
Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
Acked-by: John Johansen <john.johansen@canonical.com>
[PM: align the cap_capget() declaration, spelling fixes]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security/selinux')
| -rw-r--r-- | security/selinux/hooks.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index a0787f07d745..c816dc5de627 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -2082,7 +2082,7 @@ static int selinux_ptrace_traceme(struct task_struct *parent) SECCLASS_PROCESS, PROCESS__PTRACE, NULL); } -static int selinux_capget(struct task_struct *target, kernel_cap_t *effective, +static int selinux_capget(const struct task_struct *target, kernel_cap_t *effective, kernel_cap_t *inheritable, kernel_cap_t *permitted) { return avc_has_perm(current_sid(), task_sid_obj(target), |