diff options
author | Roger Quadros <rogerq@ti.com> | 2013-12-09 02:39:02 +0100 |
---|---|---|
committer | Paul Walmsley <paul@pwsan.com> | 2013-12-09 19:51:08 +0100 |
commit | 313a76ee11cda6700548afe68499ef174a240688 (patch) | |
tree | 9f3229756b91b02f155e055ac4ae82b62dcab324 /security/yama | |
parent | ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module (diff) | |
download | linux-313a76ee11cda6700548afe68499ef174a240688.tar.xz linux-313a76ee11cda6700548afe68499ef174a240688.zip |
ARM: OMAP2+: hwmod: Fix SOFTRESET logic
In _ocp_softreset(), after _set_softreset() + write_sysconfig(),
the hwmod's sysc_cache will always contain SOFTRESET bit set
so all further writes to sysconfig using this cache will initiate
a repeated SOFTRESET e.g. enable_sysc(). This is true for OMAP3 like
platforms that have RESET_DONE status in the SYSSTATUS register and
so the the SOFTRESET bit in SYSCONFIG is not automatically cleared.
It is not a problem for OMAP4 like platforms that indicate RESET
completion by clearing the SOFTRESET bit in the SYSCONFIG register.
This repeated SOFTRESET is undesired and was the root cause of
USB host issues on OMAP3 platforms when hwmod was allowed to do the
SOFTRESET for the USB Host module.
To fix this we clear the SOFTRESET bit and update the sysconfig
register + sysc_cache using write_sysconfig().
Signed-off-by: Roger Quadros <rogerq@ti.com>
Tested-by: Tomi Valkeinen <tomi.valkeinen@ti.com> # Panda, BeagleXM
[paul@pwsan.com: renamed _clr_softreset() to _clear_softreset()]
Signed-off-by: Paul Walmsley <paul@pwsan.com>
Diffstat (limited to 'security/yama')
0 files changed, 0 insertions, 0 deletions