diff options
| author | Paul Moore <pmoore@redhat.com> | 2013-07-23 23:38:38 +0200 |
|---|---|---|
| committer | Eric Paris <eparis@redhat.com> | 2013-07-25 19:03:27 +0200 |
| commit | b04eea886409de7460b5727b5931fb0bd417275f (patch) | |
| tree | 3be19b6275c41fc53aad1e1842723e43245a78b2 /security | |
| parent | SELinux: use a helper function to determine seclabel (diff) | |
| download | linux-b04eea886409de7460b5727b5931fb0bd417275f.tar.xz linux-b04eea886409de7460b5727b5931fb0bd417275f.zip | |
selinux: fix problems in netnode when BUG() is compiled out
When the BUG() macro is disabled at compile time it can cause some
problems in the SELinux netnode code: invalid return codes and
uninitialized variables. This patch fixes this by making sure we take
some corrective action after the BUG() macro.
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/selinux/netnode.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/security/selinux/netnode.c b/security/selinux/netnode.c index c5454c0477c3..03a72c32afd7 100644 --- a/security/selinux/netnode.c +++ b/security/selinux/netnode.c @@ -166,6 +166,7 @@ static void sel_netnode_insert(struct sel_netnode *node) break; default: BUG(); + return; } /* we need to impose a limit on the growth of the hash table so check @@ -225,6 +226,7 @@ static int sel_netnode_sid_slow(void *addr, u16 family, u32 *sid) break; default: BUG(); + ret = -EINVAL; } if (ret != 0) goto out; |