summaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorJia-Ju Bai <baijiaju1990@gmail.com>2018-04-09 17:03:53 +0200
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>2018-04-16 16:20:12 +0200
commitbb52e3169cb7dd5a9deea39b94342fce36235a5b (patch)
treecdd577f959503dd1c903f3b2ecc2f7d6414763b4 /security
parentxen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_probe (diff)
downloadlinux-bb52e3169cb7dd5a9deea39b94342fce36235a5b.tar.xz
linux-bb52e3169cb7dd5a9deea39b94342fce36235a5b.zip
xen: xen-pciback: Replace GFP_ATOMIC with GFP_KERNEL in pcistub_init_device
pcistub_init_device() is never called in atomic context. The call chain ending up at pcistub_init_device() is: [1] pcistub_init_device() <- pcistub_seize() <- pcistub_probe() [2] pcistub_init_device() <- pcistub_init_devices_late() <- xen_pcibk_init() pcistub_probe() is only set as ".probe" in struct pci_driver. xen_pcibk_init() is is only set as a parameter of module_init(). These functions are not called in atomic context. Despite never getting called from atomic context, pcistub_init_device() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions