diff options
| author | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2009-05-14 20:44:14 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-06-16 06:44:51 +0200 |
| commit | 6071d8363b7b284038069f1795a98372fbc1a48e (patch) | |
| tree | e5b56ace01d240c49b1acbdc02f17cf6a2102fdc /security | |
| parent | USB: xhci: replace if-elseif-else with switch-case (diff) | |
| download | linux-6071d8363b7b284038069f1795a98372fbc1a48e.tar.xz linux-6071d8363b7b284038069f1795a98372fbc1a48e.zip | |
usb; xhci: Fix TRB offset calculations.
Greg KH introduced a bug into xhci_trb_virt_to_dma() when he changed the
type of offset to dma_addr_t from unsigned int and dropped the casts to
unsigned int around the virtual address pointer subtraction.
trb and seg->trbs are both valid pointers to virtual addresses, so the
compiler will mod the subtraction by the size of union trb (16 bytes).
segment_offset is an unsigned long, which is guaranteed to be at least as
big as a void *.
Drop the void * casts in the first if statement because trb and seg->trbs
are both pointers of the same type (pointers to union trb).
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions