diff options
| author | Eric Biggers <ebiggers@google.com> | 2018-09-07 23:33:24 +0200 |
|---|---|---|
| committer | Mimi Zohar <zohar@linux.ibm.com> | 2018-10-10 18:56:16 +0200 |
| commit | 1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7 (patch) | |
| tree | 028e1d7d0332733c2b2d8dc23e3ab227a6dc2f37 /security | |
| parent | security/integrity: remove unnecessary 'init_keyring' variable (diff) | |
| download | linux-1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7.tar.xz linux-1e4c8dafbb6bf72fb5eca035b861e39c5896c2b7.zip | |
ima: fix showing large 'violations' or 'runtime_measurements_count'
The 12 character temporary buffer is not necessarily long enough to hold
a 'long' value. Increase it.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/integrity/ima/ima_fs.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c index fe0ede883557..3183cc23d0f8 100644 --- a/security/integrity/ima/ima_fs.c +++ b/security/integrity/ima/ima_fs.c @@ -42,14 +42,14 @@ static int __init default_canonical_fmt_setup(char *str) __setup("ima_canonical_fmt", default_canonical_fmt_setup); static int valid_policy = 1; -#define TMPBUFLEN 12 + static ssize_t ima_show_htable_value(char __user *buf, size_t count, loff_t *ppos, atomic_long_t *val) { - char tmpbuf[TMPBUFLEN]; + char tmpbuf[32]; /* greater than largest 'long' string value */ ssize_t len; - len = scnprintf(tmpbuf, TMPBUFLEN, "%li\n", atomic_long_read(val)); + len = scnprintf(tmpbuf, sizeof(tmpbuf), "%li\n", atomic_long_read(val)); return simple_read_from_buffer(buf, count, ppos, tmpbuf, len); } |