diff options
| author | Ondrej Mosnacek <omosnace@redhat.com> | 2020-04-14 16:23:51 +0200 |
|---|---|---|
| committer | Paul Moore <paul@paul-moore.com> | 2020-04-15 23:23:16 +0200 |
| commit | af15f14c8cfcee515f4e9078889045ad63efefe3 (patch) | |
| tree | 1b200b5d57bc5479434ac08daa0b15027d23f06a /security | |
| parent | selinux: clean up indentation issue with assignment statement (diff) | |
| download | linux-af15f14c8cfcee515f4e9078889045ad63efefe3.tar.xz linux-af15f14c8cfcee515f4e9078889045ad63efefe3.zip | |
selinux: free str on error in str_read()
In [see "Fixes:"] I missed the fact that str_read() may give back an
allocated pointer even if it returns an error, causing a potential
memory leak in filename_trans_read_one(). Fix this by making the
function free the allocated string whenever it returns a non-zero value,
which also makes its behavior more obvious and prevents repeating the
same mistake in the future.
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1461665 ("Resource leaks")
Fixes: c3a276111ea2 ("selinux: optimize storage of filename transitions")
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/selinux/ss/policydb.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index 70ecdc78efbd..c21b922e5ebe 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1035,14 +1035,14 @@ static int str_read(char **strp, gfp_t flags, void *fp, u32 len) if (!str) return -ENOMEM; - /* it's expected the caller should free the str */ - *strp = str; - rc = next_entry(str, fp, len); - if (rc) + if (rc) { + kfree(str); return rc; + } str[len] = '\0'; + *strp = str; return 0; } |