summaryrefslogtreecommitdiffstats
path: root/sound/drivers
diff options
context:
space:
mode:
authorSamuel Zou <zou_wei@huawei.com>2020-05-07 08:48:55 +0200
committerTakashi Iwai <tiwai@suse.de>2020-05-07 09:07:15 +0200
commit28a04aa3ba6046028036d68eab6b9f3f91b47e4e (patch)
tree2ed7cff39cf0bcd9339c299593d487eb56ebfab2 /sound/drivers
parentALSA: sound/ppc: Use bitwise instead of arithmetic operator for flags (diff)
downloadlinux-28a04aa3ba6046028036d68eab6b9f3f91b47e4e.tar.xz
linux-28a04aa3ba6046028036d68eab6b9f3f91b47e4e.zip
ALSA: portman2x4: Use bitwise instead of arithmetic operator for flags
Fix the following coccinelle warning: sound/drivers/portman2x4.c:460:34-35: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Samuel Zou <zou_wei@huawei.com> Link: https://lore.kernel.org/r/1588834135-14842-1-git-send-email-zou_wei@huawei.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/drivers')
-rw-r--r--sound/drivers/portman2x4.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index ecefa7c83134..38603cb2bd5b 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -457,7 +457,7 @@ static int portman_probe(struct parport *p)
/* Set for RXDATA0 where no damage will be done. */
/* 5 */
- parport_write_control(p, RXDATA0 + STROBE); /* Write Strobe=1 to command reg. */
+ parport_write_control(p, RXDATA0 | STROBE); /* Write Strobe=1 to command reg. */
/* 6 */
if ((parport_read_status(p) & ESTB) != ESTB)