diff options
author | Takashi Iwai <tiwai@suse.de> | 2016-02-03 08:32:44 +0100 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2016-02-03 14:51:51 +0100 |
commit | 7f0973e973cd74aa40747c9d38844560cd184ee8 (patch) | |
tree | 995f82e9dfe6c69c8c6136f61be99577de81a85b /sound/isa/cs423x/cs4231.c | |
parent | ALSA: rawmidi: Fix race at copying & updating the position (diff) | |
download | linux-7f0973e973cd74aa40747c9d38844560cd184ee8.tar.xz linux-7f0973e973cd74aa40747c9d38844560cd184ee8.zip |
ALSA: seq: Fix lockdep warnings due to double mutex locks
The port subscription code uses double mutex locks for source and
destination ports, and this may become racy once when wrongly set up.
It leads to lockdep warning splat, typically triggered by fuzzer like
syzkaller, although the actual deadlock hasn't been seen, so far.
This patch simplifies the handling by reducing to two single locks, so
that no lockdep warning will be trigger any longer.
By splitting to two actions, a still-in-progress element shall be
added in one list while handling another. For ignoring this element,
a new check is added in deliver_to_subscribers().
Along with it, the code to add/remove the subscribers list element was
cleaned up and refactored.
BugLink: http://lkml.kernel.org/r/CACT4Y+aKQXV7xkBW9hpQbzaDO7LrUvohxWh-UwMxXjDy-yBD=A@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Tested-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa/cs423x/cs4231.c')
0 files changed, 0 insertions, 0 deletions