diff options
author | Takashi Iwai <tiwai@suse.de> | 2022-04-12 11:31:41 +0200 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2022-04-12 11:48:09 +0200 |
commit | 313c7e57035125cb7533b53ddd0bc7aa562b433c (patch) | |
tree | b4b534b693c8ef7e6803d9d7e1b981eb7a0a1e9b /sound/isa/galaxy/galaxy.c | |
parent | ALSA: core: Add snd_card_free_on_error() helper (diff) | |
download | linux-313c7e57035125cb7533b53ddd0bc7aa562b433c.tar.xz linux-313c7e57035125cb7533b53ddd0bc7aa562b433c.zip |
ALSA: echoaudio: Fix the missing snd_card_free() call at probe error
The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature. Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().
This patch fixes it by calling snd_card_free() on the error from the
probe callback using a new helper function.
Fixes: 9c211bf392bb ("ALSA: echoaudio: Allocate resources with device-managed APIs")
Reported-and-tested-by: Zheyu Ma <zheyuma97@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/CAMhUBjm2AdyEZ_-EgexdNDN7SvY4f89=4=FwAL+c0Mg0O+X50A@mail.gmail.com
Link: https://lore.kernel.org/r/20220412093141.8008-3-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa/galaxy/galaxy.c')
0 files changed, 0 insertions, 0 deletions