diff options
| author | Eugene Teo <eugene.teo@eugeneteo.net> | 2006-03-17 16:32:52 +0100 |
|---|---|---|
| committer | Jaroslav Kysela <perex@suse.cz> | 2006-03-22 10:39:25 +0100 |
| commit | d61975fc6b40dadd2cd61fc9535499c7d7b806de (patch) | |
| tree | a3203048ad4b84ba10b1337902d9d08010b902c7 /sound/isa | |
| parent | [ALSA] Fix seq_clientmgr dereferences before NULL check (diff) | |
| download | linux-d61975fc6b40dadd2cd61fc9535499c7d7b806de.tar.xz linux-d61975fc6b40dadd2cd61fc9535499c7d7b806de.zip | |
[ALSA] Fix gus_pcm dereference before NULL
Modules: GUS Library
The NULL check of substream is simply superfluous. It is
guaranteed to receive non-NULL substream. Thanks Takashi.
Coverity bug #861
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa')
| -rw-r--r-- | sound/isa/gus/gus_pcm.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c index d0829393ec8a..c7f95e7aa018 100644 --- a/sound/isa/gus/gus_pcm.c +++ b/sound/isa/gus/gus_pcm.c @@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(struct snd_pcm_substream *substream) unsigned char pan; unsigned int voice; - if (substream == NULL) - return; spin_lock_irqsave(&pcmp->lock, flags); if (pcmp->flags & SNDRV_GF1_PCM_PFLG_ACTIVE) { spin_unlock_irqrestore(&pcmp->lock, flags); |