diff options
author | Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-04-26 19:06:20 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-14 13:46:48 +0200 |
commit | 7272b591c4cb9327c43443f67b8fbae7657dd9ae (patch) | |
tree | 8eddccc6033b1a32b9f0c490fe4a57bf6f9b00de /sound/mips/snd-n64.c | |
parent | sparc/vio: make remove callback return void (diff) | |
download | linux-7272b591c4cb9327c43443f67b8fbae7657dd9ae.tar.xz linux-7272b591c4cb9327c43443f67b8fbae7657dd9ae.zip |
misc/libmasm/module: Fix two use after free in ibmasm_init_one
In ibmasm_init_one, it calls ibmasm_init_remote_input_dev().
Inside ibmasm_init_remote_input_dev, mouse_dev and keybd_dev are
allocated by input_allocate_device(), and assigned to
sp->remote.mouse_dev and sp->remote.keybd_dev respectively.
In the err_free_devices error branch of ibmasm_init_one,
mouse_dev and keybd_dev are freed by input_free_device(), and return
error. Then the execution runs into error_send_message error branch
of ibmasm_init_one, where ibmasm_free_remote_input_dev(sp) is called
to unregister the freed sp->remote.mouse_dev and sp->remote.keybd_dev.
My patch add a "error_init_remote" label to handle the error of
ibmasm_init_remote_input_dev(), to avoid the uaf bugs.
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Link: https://lore.kernel.org/r/20210426170620.10546-1-lyl2019@mail.ustc.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/mips/snd-n64.c')
0 files changed, 0 insertions, 0 deletions