summaryrefslogtreecommitdiffstats
path: root/sound/oss/sb_audio.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-11-17 16:08:57 +0100
committerTakashi Iwai <tiwai@suse.de>2012-11-18 10:24:49 +0100
commit379170a42c84cee5f95fac536a4b5b76843baf90 (patch)
tree711883cc5769c9d9cfccfcf211bc6a9b29d1de41 /sound/oss/sb_audio.c
parentALSA: usb-audio: use bitmap_weight (diff)
downloadlinux-379170a42c84cee5f95fac536a4b5b76843baf90.tar.xz
linux-379170a42c84cee5f95fac536a4b5b76843baf90.zip
sound: oss/sb_audio: cap value in sb201_audio_set_speed()
We set "s" before we have capped "speed" so it could be the wrong value. This could lead to a divide by zero bug. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to '')
-rw-r--r--sound/oss/sb_audio.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/oss/sb_audio.c b/sound/oss/sb_audio.c
index b2b3c014221a..048439a16000 100644
--- a/sound/oss/sb_audio.c
+++ b/sound/oss/sb_audio.c
@@ -442,7 +442,7 @@ static int sb201_audio_set_speed(int dev, int speed)
{
sb_devc *devc = audio_devs[dev]->devc;
int tmp;
- int s = speed * devc->channels;
+ int s;
if (speed > 0)
{
@@ -452,6 +452,7 @@ static int sb201_audio_set_speed(int dev, int speed)
speed = 44100;
if (devc->opened & OPEN_READ && speed > 15000)
speed = 15000;
+ s = speed * devc->channels;
devc->tconst = (256 - ((1000000 + s / 2) / s)) & 0xff;
tmp = 256 - devc->tconst;
speed = ((1000000 + tmp / 2) / tmp) / devc->channels;