diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-08-07 11:19:27 +0200 |
---|---|---|
committer | Helge Deller <deller@gmx.de> | 2021-08-30 10:18:25 +0200 |
commit | 87875c1084a28364dad8cd4f9ecbfdfe0b845ad5 (patch) | |
tree | cdb664f154ac23a7053af31401d56a92c8b953d3 /sound/parisc | |
parent | parisc: remove unused arch/parisc/boot/install.sh and its phony target (diff) | |
download | linux-87875c1084a28364dad8cd4f9ecbfdfe0b845ad5.tar.xz linux-87875c1084a28364dad8cd4f9ecbfdfe0b845ad5.zip |
parisc: Make struct parisc_driver::remove() return void
The caller of this function (parisc_driver_remove() in
arch/parisc/kernel/drivers.c) ignores the return value, so better don't
return any value at all to not wake wrong expectations in driver authors.
The only function that could return a non-zero value before was
ipmi_parisc_remove() which returns the return value of
ipmi_si_remove_by_dev(). Make this function return void, too, as for all
other callers the value is ignored, too.
Also fold in a small checkpatch fix for:
WARNING: Unnecessary space before function pointer arguments
+ void (*remove) (struct parisc_device *dev);
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> (for drivers/input)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'sound/parisc')
-rw-r--r-- | sound/parisc/harmony.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c index 1440db8b4177..2e3e5aa47682 100644 --- a/sound/parisc/harmony.c +++ b/sound/parisc/harmony.c @@ -968,11 +968,10 @@ free_and_ret: return err; } -static int __exit +static void __exit snd_harmony_remove(struct parisc_device *padev) { snd_card_free(parisc_get_drvdata(padev)); - return 0; } static struct parisc_driver snd_harmony_driver __refdata = { |