diff options
| author | Takashi Iwai <tiwai@suse.de> | 2015-02-27 17:43:19 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2015-03-03 11:26:24 +0100 |
| commit | bbbc7e8502c95237dbd86cc4d0a12ca9a6b18c8f (patch) | |
| tree | 71d5973b321c194ca5b9fd76592844eb37c4c9ed /sound/pci/hda/hda_generic.h | |
| parent | ALSA: hda - Remove superfluous memory allocation error messages (diff) | |
| download | linux-bbbc7e8502c95237dbd86cc4d0a12ca9a6b18c8f.tar.xz linux-bbbc7e8502c95237dbd86cc4d0a12ca9a6b18c8f.zip | |
ALSA: hda - Allocate hda_pcm objects dynamically
So far, the hda_codec object kept the hda_pcm list in an array, and
the codec driver was expected to assign the array. However, this
makes the object life cycle management harder, because the assigned
array is freed at the codec driver detach while it might be still
accessed by the opened streams.
In this patch, we allocate each hda_pcm object dynamically and manage
it as a linked list. Each object has a kref refcount, and both the
codec driver binder and the PCM open/close touches it, so that the
object won't be freed while in use.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda/hda_generic.h')
| -rw-r--r-- | sound/pci/hda/hda_generic.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/hda/hda_generic.h b/sound/pci/hda/hda_generic.h index 3d852660443a..b211f889b335 100644 --- a/sound/pci/hda/hda_generic.h +++ b/sound/pci/hda/hda_generic.h @@ -144,7 +144,7 @@ struct hda_gen_spec { int const_channel_count; /* channel count for all */ /* PCM information */ - struct hda_pcm pcm_rec[3]; /* used in build_pcms() */ + struct hda_pcm *pcm_rec[3]; /* used in build_pcms() */ /* dynamic controls, init_verbs and input_mux */ struct auto_pin_cfg autocfg; |