diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-12 23:46:33 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-12 23:46:33 +0100 |
commit | f01eb3640308c005d31b29d0a8bc2b7acb4e3f75 (patch) | |
tree | a4e249cc4b5880b841487c889c32be8b5414fd11 /sound/pci/hda | |
parent | tty: Fix BKL taken under a spinlock bug introduced in the BKL split (diff) | |
download | linux-f01eb3640308c005d31b29d0a8bc2b7acb4e3f75.tar.xz linux-f01eb3640308c005d31b29d0a8bc2b7acb4e3f75.zip |
[BKL] add 'might_sleep()' to the outermost lock taker
As shown by the previous patch (6698e3472: "tty: Fix BKL taken under a
spinlock bug introduced in the BKL split") the BKL removal is prone to
some subtle issues, where removing the BKL in one place may in fact make
a previously nested BKL call the new outer call, and then prone to nasty
deadlocks with other spinlocks.
In general, we should never take the BKL while we're holding a spinlock,
so let's just add a "might_sleep()" to it (even though the BKL doesn't
technically sleep - at least not yet), and we'll get nice warnings the
next time this kind of problem happens during BKL removal.
Acked-and-Tested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'sound/pci/hda')
0 files changed, 0 insertions, 0 deletions