diff options
| author | Sudip Mukherjee <sudip@vectorindia.org> | 2014-11-14 13:42:21 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2014-11-14 14:16:47 +0100 |
| commit | b8eca77e54525c818f35f51afb64fc13205443a3 (patch) | |
| tree | b94c0620ca369679c566d23d36cfaa896f2573e9 /sound/pci/ice1712/revo.c | |
| parent | ALSA: ice1712: remove unused variable (diff) | |
| download | linux-b8eca77e54525c818f35f51afb64fc13205443a3.tar.xz linux-b8eca77e54525c818f35f51afb64fc13205443a3.zip | |
ALSA: ice1712: consider error value
earlier we were ignoring the return value of snd_ak4114_create and
always returning 0.
now we are returning the actual status. revo_init is calling this
function, and revo_init is checking the return value.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/ice1712/revo.c')
| -rw-r--r-- | sound/pci/ice1712/revo.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c index 1112ec1953be..1d81ae677573 100644 --- a/sound/pci/ice1712/revo.c +++ b/sound/pci/ice1712/revo.c @@ -494,11 +494,13 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) ap192_ak4114_write, ak4114_init_vals, ak4114_init_txcsb, ice, &spec->ak4114); + if (err < 0) + return err; /* AK4114 in Revo cannot detect external rate correctly. * No reason to stop capture stream due to incorrect checks */ spec->ak4114->check_flags = AK4114_CHECK_NO_RATE; - return 0; /* error ignored; it's no fatal error */ + return 0; } static int revo_init(struct snd_ice1712 *ice) |