summaryrefslogtreecommitdiffstats
path: root/sound/pci
diff options
context:
space:
mode:
authorDenis Efremov <yefremov.denis@gmail.com>2013-02-11 16:49:48 +0100
committerTakashi Iwai <tiwai@suse.de>2013-02-11 16:52:46 +0100
commitdacae5a19b4cbe1b5e3a86de23ea74cbe9ec9652 (patch)
tree64b108a9fc93221f56e3a9fec6b9b774ce98bf95 /sound/pci
parentALSA: rme32.c irq enabling after spin_lock_irq (diff)
downloadlinux-dacae5a19b4cbe1b5e3a86de23ea74cbe9ec9652.tar.xz
linux-dacae5a19b4cbe1b5e3a86de23ea74cbe9ec9652.zip
ALSA: ali5451: remove irq enabling in pointer callback
snd_ali_pointer function is called with local interrupts disabled. However it seems very strange to reenable them in such way. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov <yefremov.denis@gmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci')
-rw-r--r--sound/pci/ali5451/ali5451.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c
index 136a393b70ab..e760af9d1fb6 100644
--- a/sound/pci/ali5451/ali5451.c
+++ b/sound/pci/ali5451/ali5451.c
@@ -1435,7 +1435,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream)
spin_lock(&codec->reg_lock);
if (!pvoice->running) {
- spin_unlock_irq(&codec->reg_lock);
+ spin_unlock(&codec->reg_lock);
return 0;
}
outb(pvoice->number, ALI_REG(codec, ALI_GC_CIR));