diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-11 21:05:49 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-02-12 20:13:40 +0100 |
| commit | 681c896ceb411ccd2ce0a88059d86ccf8d7a497e (patch) | |
| tree | 2fb21e0a90843534b404362ecb90ed1674f8e013 /sound/soc/codecs/wm0010.c | |
| parent | ASoC: sh: fsi: Restore devm_ioremap() alignment (diff) | |
| download | linux-681c896ceb411ccd2ce0a88059d86ccf8d7a497e.tar.xz linux-681c896ceb411ccd2ce0a88059d86ccf8d7a497e.zip | |
ASoC: wm0010: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200211200549.GA12072@embeddedor
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/wm0010.c')
| -rw-r--r-- | sound/soc/codecs/wm0010.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c index 727d6703c905..fbcee21736e8 100644 --- a/sound/soc/codecs/wm0010.c +++ b/sound/soc/codecs/wm0010.c @@ -43,7 +43,7 @@ struct dfw_binrec { u8 command; u32 length:24; u32 address; - uint8_t data[0]; + uint8_t data[]; } __packed; struct dfw_inforec { |