diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-10-13 09:08:18 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2015-10-22 14:54:13 +0200 |
| commit | 931dfa6931448ccfd12d4ccd8d1d9289ceb92439 (patch) | |
| tree | 15e5684c4a4bd9f5373afbc0e5283bbf518e478d /sound/soc/codecs/wm8904.c | |
| parent | Linux 4.3-rc1 (diff) | |
| download | linux-931dfa6931448ccfd12d4ccd8d1d9289ceb92439.tar.xz linux-931dfa6931448ccfd12d4ccd8d1d9289ceb92439.zip | |
ASoC: wm8904: harmless underflow in wm8904_put_deemph()
We try to check that "deemph" is zero or one, but because of an
underflow bug, it can also be negative. It's fine, negative values are
handled as non-zero. But it's messy and static checkers complain so
let's fix it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/wm8904.c')
| -rw-r--r-- | sound/soc/codecs/wm8904.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c index b783743dc97e..2aa23f1b9e3c 100644 --- a/sound/soc/codecs/wm8904.c +++ b/sound/soc/codecs/wm8904.c @@ -534,7 +534,7 @@ static int wm8904_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; if (deemph > 1) return -EINVAL; |