diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-10-14 00:19:50 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-10-23 14:29:45 +0200 |
| commit | 393df6f321c757d164fa412b7eae527a8e2acb75 (patch) | |
| tree | ab01351779803126c5ae6730eeba05ece4e11ead /sound/soc/generic/audio-graph-card.c | |
| parent | ASoC: starfive/jh7110-pwmdac: Convert to platform remove callback returning void (diff) | |
| download | linux-393df6f321c757d164fa412b7eae527a8e2acb75.tar.xz linux-393df6f321c757d164fa412b7eae527a8e2acb75.zip | |
ASoC: simple-card-utils: Make simple_util_remove() return void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
simple_util_remove() returned zero unconditionally. Make it return void
instead and convert all users to struct platform_device::remove_new().
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Herve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20231013221945.1489203-13-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/generic/audio-graph-card.c')
| -rw-r--r-- | sound/soc/generic/audio-graph-card.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 704f32bda24d..76a9f1e8cdd5 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -644,7 +644,7 @@ static struct platform_driver graph_card = { .of_match_table = graph_of_match, }, .probe = graph_probe, - .remove = simple_util_remove, + .remove_new = simple_util_remove, }; module_platform_driver(graph_card); |