summaryrefslogtreecommitdiffstats
path: root/sound/soc/mediatek/mt2701/mt2701-reg.h
diff options
context:
space:
mode:
authorCharles Keepax <ckeepax@opensource.cirrus.com>2018-01-26 14:08:43 +0100
committerMark Brown <broonie@kernel.org>2018-01-26 16:22:52 +0100
commit290df4d3ab192821b66857c05346b23056ee9545 (patch)
tree3002381419f36498d97398aee64a5347acabbc0d /sound/soc/mediatek/mt2701/mt2701-reg.h
parentLinux 4.15-rc1 (diff)
downloadlinux-290df4d3ab192821b66857c05346b23056ee9545.tar.xz
linux-290df4d3ab192821b66857c05346b23056ee9545.zip
ASoC: compress: Correct handling of copy callback
The soc_compr_copy callback is currently broken. Since the changes to move the compr_ops over to the component the return value is not correctly propagated, always returning zero on success rather than the number of bytes copied. This causes user-space to stall continuously reading as it does not believe it has received any data. Furthermore, the changes to move the compr_ops over to the component iterate through the list of components and will call the copy callback for any that have compressed ops. There isn't currently any consensus on the mechanism to combine the results of multiple copy callbacks. To fix this issue for now halt searching the component list when we locate a copy callback and return the result of that single callback. Additional work should probably be done to look at the other ops, tidy things up, and work out if we want to support multiple components on a single compressed, but this is the only fix required to get things working again. Fixes: 9e7e3738ab0e ("ASoC: snd_soc_component_driver has snd_compr_ops") Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> Signed-off-by: Mark Brown <broonie@kernel.org> Cc: stable@vger.kernel.org
Diffstat (limited to 'sound/soc/mediatek/mt2701/mt2701-reg.h')
0 files changed, 0 insertions, 0 deletions