diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-04-04 11:29:01 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-04-05 11:44:30 +0200 |
| commit | 4f4e0454e226de3bf4efd7e7924d1edc571c52d5 (patch) | |
| tree | 071e10150fac634335c24e2b0f56bb10cc1b20b5 /sound/soc/mediatek/mt8173 | |
| parent | ASoC: Pull in fixes (diff) | |
| download | linux-4f4e0454e226de3bf4efd7e7924d1edc571c52d5.tar.xz linux-4f4e0454e226de3bf4efd7e7924d1edc571c52d5.zip | |
ASoC: mediatek: Fix error handling in mt8173_max98090_dev_probe
Call of_node_put(platform_node) to avoid refcount leak in
the error path.
Fixes: 94319ba10eca ("ASoC: mediatek: Use platform_of_node for machine drivers")
Fixes: 493433785df0 ("ASoC: mediatek: mt8173: fix device_node leak")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220404092903.26725-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/mediatek/mt8173')
| -rw-r--r-- | sound/soc/mediatek/mt8173/mt8173-max98090.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sound/soc/mediatek/mt8173/mt8173-max98090.c b/sound/soc/mediatek/mt8173/mt8173-max98090.c index 4cb90da89262..58778cd2e61b 100644 --- a/sound/soc/mediatek/mt8173/mt8173-max98090.c +++ b/sound/soc/mediatek/mt8173/mt8173-max98090.c @@ -167,7 +167,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev) if (!codec_node) { dev_err(&pdev->dev, "Property 'audio-codec' missing or invalid\n"); - return -EINVAL; + ret = -EINVAL; + goto put_platform_node; } for_each_card_prelinks(card, i, dai_link) { if (dai_link->codecs->name) @@ -179,6 +180,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, card); of_node_put(codec_node); + +put_platform_node: of_node_put(platform_node); return ret; } |