diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2014-08-17 16:18:19 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-08-17 16:33:11 +0200 |
| commit | c8e6e960733f4a5835265c15429fced4d2f1595e (patch) | |
| tree | 433e3239e7041fbe628ea77921e6dd223b94412a /sound/soc/sh | |
| parent | Linux 3.17-rc1 (diff) | |
| download | linux-c8e6e960733f4a5835265c15429fced4d2f1595e.tar.xz linux-c8e6e960733f4a5835265c15429fced4d2f1595e.zip | |
ASoC: rcar: Use && instead of & for boolean expressions
Sparse spits out the following warning:
sound/soc/sh/rcar/gen.c:250:21: warning: dubious: x & !y
It does this because sometimes mixing boolean and bit-wise logic has not the
intended result. In this case we are fine, but replacing the bit-wise '&' with
the boolean '&&' silences the sparse warning. The generated code for both cases
is the same.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/sh')
| -rw-r--r-- | sound/soc/sh/rcar/gen.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c index 3fdf3be7b99a..f95e7ab135e8 100644 --- a/sound/soc/sh/rcar/gen.c +++ b/sound/soc/sh/rcar/gen.c @@ -247,7 +247,7 @@ rsnd_gen2_dma_addr(struct rsnd_priv *priv, }; /* it shouldn't happen */ - if (use_dvc & !use_src) + if (use_dvc && !use_src) dev_err(dev, "DVC is selected without SRC\n"); /* use SSIU or SSI ? */ |