diff options
| author | Martin Povišer <povik+lin@cutebit.org> | 2022-08-18 18:53:36 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-08-19 14:19:59 +0200 |
| commit | ceff365a29aaf275c0cd1bb7edaf57dcf254bc77 (patch) | |
| tree | a04e11358f5c7f19f63ab2b70f080914ac71fd53 /sound/soc/soc-dai.c | |
| parent | ASoC: amd: acp: add a label to make error path more clean (diff) | |
| download | linux-ceff365a29aaf275c0cd1bb7edaf57dcf254bc77.tar.xz linux-ceff365a29aaf275c0cd1bb7edaf57dcf254bc77.zip | |
ASoC: Change handling of unimplemented set_bclk_ratio
If a 'set_bclk_ratio' call is attempted on a DAI not implementing the
method, make it an -ENOSUPP error instead of -EINVAL. Assume the DAI can
still be okay with the ratio, just does not care to register a handler.
No current in-tree users of snd_soc_dai_set_bclk_ratio seem to inspect
the return value, but -ENOSUPP disables an error print from within the
common soc_dai_ret return filter. With the new behavior a machine
driver can do a blanket 'set_bclk_ratio' on all DAIs on a bus, some of
which may care about the ratio, some of which may not.
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20220818165336.76403-1-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/soc-dai.c')
| -rw-r--r-- | sound/soc/soc-dai.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c index d530e8c2b77b..49752af0e205 100644 --- a/sound/soc/soc-dai.c +++ b/sound/soc/soc-dai.c @@ -124,7 +124,7 @@ EXPORT_SYMBOL_GPL(snd_soc_dai_set_pll); */ int snd_soc_dai_set_bclk_ratio(struct snd_soc_dai *dai, unsigned int ratio) { - int ret = -EINVAL; + int ret = -ENOTSUPP; if (dai->driver->ops && dai->driver->ops->set_bclk_ratio) |