diff options
| author | Xiubo Li <Li.Xiubo@freescale.com> | 2014-01-16 09:08:04 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2014-01-16 15:11:49 +0100 |
| commit | ec4f2857cd41b7c5af6350e7ab2a8fe1874dae59 (patch) | |
| tree | 15229e716b34f21fdd633c13e1a47efbecce22f8 /sound/soc/soc-generic-dmaengine-pcm.c | |
| parent | ASoC: samsung: Remove SND_DMAENGINE_PCM_FLAG_NO_RESIDUE flag (diff) | |
| download | linux-ec4f2857cd41b7c5af6350e7ab2a8fe1874dae59.tar.xz linux-ec4f2857cd41b7c5af6350e7ab2a8fe1874dae59.zip | |
ASoC: core: Fix possible NULL pointer dereference of pcm->config
Since the soc generic dmaengine pcm driver allows using the defualt settings,
so the pcm->config maybe NULL.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/soc-generic-dmaengine-pcm.c')
| -rw-r--r-- | sound/soc/soc-generic-dmaengine-pcm.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/sound/soc/soc-generic-dmaengine-pcm.c b/sound/soc/soc-generic-dmaengine-pcm.c index 560a7787d8a7..5bace124ef43 100644 --- a/sound/soc/soc-generic-dmaengine-pcm.c +++ b/sound/soc/soc-generic-dmaengine-pcm.c @@ -176,17 +176,20 @@ static struct dma_chan *dmaengine_pcm_compat_request_channel( { struct dmaengine_pcm *pcm = soc_platform_to_pcm(rtd->platform); struct snd_dmaengine_dai_dma_data *dma_data; + dma_filter_fn fn = NULL; dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream); if ((pcm->flags & SND_DMAENGINE_PCM_FLAG_HALF_DUPLEX) && pcm->chan[0]) return pcm->chan[0]; - if (pcm->config->compat_request_channel) + if (pcm->config && pcm->config->compat_request_channel) return pcm->config->compat_request_channel(rtd, substream); - return snd_dmaengine_pcm_request_channel(pcm->config->compat_filter_fn, - dma_data->filter_data); + if (pcm->config) + fn = pcm->config->compat_filter_fn; + + return snd_dmaengine_pcm_request_channel(fn, dma_data->filter_data); } static bool dmaengine_pcm_can_report_residue(struct dma_chan *chan) |